Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the current tag to the page title #2819

Merged
merged 1 commit into from Jun 26, 2019

Conversation

Projects
None yet
5 participants
@StijnVrolijk
Copy link
Contributor

commented May 27, 2019

Type

  • Enhancement

Pull request description

This simply adds the current tag to the page title, useful for SEO and the likes.

@StijnVrolijk StijnVrolijk added this to the 5.6.0 milestone May 27, 2019

@StijnVrolijk StijnVrolijk requested review from forkcms/core-contributors May 27, 2019

@StijnVrolijk StijnVrolijk changed the title Add the current tage to the page title Add the current tag to the page title May 27, 2019

@Sellato

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

I think it's need to change the order of fields. Looks not so good.

<title>hat - Tags - Etsy Shop Goods and Gifts</title>

where:
hat - is tag
Tags - is a module name
Etsy Shop Goods and Gifts - is site Title

@Sellato

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

This simply adds the current tag to the page title, useful for SEO and the likes.

This lines kill the SEO :)
at lines 64-65

    // tag-pages don't have any SEO-value, so don't index them
    $this->header->addMetaData(['name' => 'robots', 'content' => 'noindex, follow'], true);
@StijnVrolijk

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

@Sellato hehe, you are correct, I missed that. Anyway, it still looks better when you share or bookmark the link.

I wonder why that decision was made, though? To me it seems pretty useful to have search engines index a page where you can find all sorts of other pages with a certain tag.

@tijsverkoyen I see you added that line way back in 2011, can you tell me why?

@tijsverkoyen

This comment has been minimized.

Copy link
Member

commented May 28, 2019

I can remember Bseen (now part of Wijs) had audited Fork on SEO. So probably feedback from them.

@carakas carakas merged commit 6161dd1 into master Jun 26, 2019

5 checks passed

Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@carakas carakas deleted the tag-in-page-title branch Jun 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.