Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2836 pages seo navigation title #2844

Merged
merged 2 commits into from Jun 27, 2019

Conversation

Projects
None yet
2 participants
@carakas
Copy link
Member

commented Jun 26, 2019

Type

  • Non critical bugfix

Resolves the following issues

fixes #2836

Pull request description

The navigation title wasn't validated. Leaving it empty didn't result in errors because of the fallback in case we don't overwrite it but it should happen.

@carakas carakas added this to the 5.6.0 milestone Jun 26, 2019

@carakas carakas requested a review from forkcms/core-contributors Jun 26, 2019

@carakas carakas merged commit 76962c9 into forkcms:master Jun 27, 2019

3 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@carakas carakas deleted the justcarakas:2836-pages-seo-navigation-title branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.