Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a link for the last item of a breadcrumb #2846

Conversation

Projects
None yet
2 participants
@carakas
Copy link
Member

commented Jun 26, 2019

Type

  • Enhancement

Resolves the following issues

fixes #2824

Pull request description

We shouldn't use a link as the last item of a breadcrumb since it is the current page. I fixed it in the template instead of the php so people still have the option to access the url if they want in their theme

@carakas carakas added this to the 5.6.0 milestone Jun 26, 2019

@carakas carakas requested review from forkcms/core-contributors Jun 26, 2019

@carakas carakas merged commit 8733062 into forkcms:master Jun 27, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details

@carakas carakas deleted the justcarakas:2824-fix-last-item-in-breadcrumb-should-not-be-a-link branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.