Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2830 add page context to symfony debug bar #2852

Merged

Conversation

Projects
None yet
3 participants
@carakas
Copy link
Member

commented Jul 1, 2019

Type

  • Feature

Resolves the following issues

closes #2830

Pull request description

This will add a section to the Symfony Debug Toolbar and give you some extra information about the page you are watching.

When there is no data (Backend)

Screenshot 2019-07-01 at 18 32 01

When there is both a block and a widget

Screenshot 2019-07-01 at 18 31 31

Screenshot 2019-07-01 at 18 30 41

When there is both a no block but there is a widget

Screenshot 2019-07-01 at 18 31 14

Screenshot 2019-07-01 at 18 30 53

@carakas carakas added this to the 5.6.0 milestone Jul 1, 2019

@carakas carakas requested a review from forkcms/core-contributors Jul 2, 2019

@WouterSioen
Copy link
Member

left a comment

Very cool feature 👌

@ohvitorino

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

@carakas a counter on the button with the amount of widgets would also be nice :)

@WouterSioen

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

But do you also contain the main block into account then? It would probably be weird to have 0 as count on a page with only a module and no widgets?

An aggregated count of all blocks on the page might be nice though 👌

@carakas

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

I implemented it now like this.
No visible count if there are no widgets. Just like the block info is also not shown if it is null.

Screenshot 2019-07-02 at 08 49 44

Screenshot 2019-07-02 at 08 49 57

Screenshot 2019-07-02 at 08 49 53

@carakas

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

@WouterSioen do you think it is oke like that? cause I'm not sure if also counting things like the html from the editors in the backend adds value

@WouterSioen

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

It's a pretty good improvement already. I think you'll get a feeling real quick if that would provide value once you start using this part of the debug bar.

@carakas carakas merged commit ac7615b into forkcms:master Jul 2, 2019

3 checks passed

Scrutinizer Analysis: 20 updated code elements – Tests: passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@carakas carakas deleted the justcarakas:2830-add-page-context-to-symfony-debug-bar branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.