Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the delete possition on the last remaining possition #2856

Conversation

Projects
None yet
4 participants
@carakas
Copy link
Member

commented Jul 2, 2019

Type

  • Enhancement

Resolves the following issues

fixes #2786

Pull request description

The first template position could not be deleted.
This has now changed to the last remaining position

####Before
Screenshot 2019-07-02 at 12 08 24

####After
Screenshot 2019-07-02 at 12 07 57
Screenshot 2019-07-02 at 12 07 53

@carakas carakas added this to the 5.6.0 milestone Jul 2, 2019

@carakas carakas requested review from forkcms/core-contributors Jul 2, 2019

@carakas carakas merged commit 866ed7e into forkcms:master Jul 3, 2019

3 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@carakas carakas deleted the justcarakas:2786-first-template-position-cannot-be-deleted branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.