Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show session timeout warning 15min after page load #2858

Merged
merged 3 commits into from Oct 3, 2019

Conversation

@Katrienvh
Copy link
Contributor

Katrienvh commented Jul 9, 2019

Type

  • Enhancement

Resolves the following issues

Losing changes because your session expired without any warning.

Pull request description

Now there will appear a warning 15 minutes after page load, with the message to recommend the user to (temporary) save the changes that are made.

@carakas

This comment has been minimized.

Copy link
Member

carakas commented Jul 9, 2019

@Katrienvh is session timeout on all servers the same? Wouldn't it be better to look at the server config and then subtract like 5 minutes or so?

@StijnVrolijk

This comment has been minimized.

Copy link
Contributor

StijnVrolijk commented Jul 9, 2019

What if the "save" action uses an ajax call? Wouldn't the message have to be shown again after x minutes?

@StijnVrolijk StijnVrolijk requested review from forkcms/core-contributors Jul 9, 2019
@StijnVrolijk StijnVrolijk added the Feature label Jul 9, 2019
@StijnVrolijk StijnVrolijk added this to the 5.7.0 milestone Jul 9, 2019
@Katrienvh Katrienvh closed this Jul 17, 2019
@Katrienvh

This comment has been minimized.

Copy link
Contributor Author

Katrienvh commented Jul 17, 2019

What if the "save" action uses an ajax call? Wouldn't the message have to be shown again after x minutes?
@StijnVrolijk fixed in 9e03fd6

@StijnVrolijk StijnVrolijk reopened this Jul 17, 2019
@carakas
carakas approved these changes Oct 3, 2019
@carakas carakas merged commit caa24b5 into forkcms:master Oct 3, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.