Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change arrow function to a plain old function #2873

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@StijnVrolijk
Copy link
Contributor

commented Aug 7, 2019

Type

  • Critical bugfix

Pull request description

An arrow style function was present in frontend.js but Internet Explorer (all versions) can't handle this so it breaks all JavaScript on the frontend. This pull request reverts it to a plain old function () {} so it works on all browsers.

@StijnVrolijk StijnVrolijk added this to the 5.6.2 milestone Aug 7, 2019

@StijnVrolijk StijnVrolijk requested review from forkcms/core-contributors Aug 7, 2019

@carakas carakas merged commit a77a93c into master Aug 14, 2019

5 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@carakas carakas deleted the arrow-to-plane branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.