Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert + to %20 in mailto urls #2874

merged 1 commit into from Aug 14, 2019


Copy link

commented Aug 7, 2019


  • Non critical bugfix

Pull request description

Previously, if you created a mailto link with spaces in the subject and/or body, the url would contain "+" instead of spaces (because of url.toString()) and those "+"'s would end up in the mail clients.

This pull request converts those "+"'s to "%20" which get converted to actual spaces by the mail clients.

@StijnVrolijk StijnVrolijk added the Bug label Aug 7, 2019

@StijnVrolijk StijnVrolijk added this to the 5.6.2 milestone Aug 7, 2019

@StijnVrolijk StijnVrolijk requested review from forkcms/core-contributors Aug 7, 2019

@carakas carakas merged commit 34b33f5 into master Aug 14, 2019

5 checks passed

Scrutinizer No new issues
continuous-integration/styleci/pr The analysis has passed
continuous-integration/styleci/push The analysis has passed
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@carakas carakas deleted the mailto-encoding branch Aug 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.