Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Helper JS triggered twice #2903

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@cirykpopeye
Copy link
Contributor

cirykpopeye commented Sep 18, 2019

Type

  • Non critical bugfix

Pull request description

When opening the model the fineuploader gets triggered once again, but it's already been trigger the moment the page was loaded. This causes two dropzone's and when dragging in images it uploads each image twice or more depending on how many times you trigger the modal.

When opening the model the fineuploader gets triggered once again, but it's already been trigger the moment the page was loaded. This causes two dropzone's and when dragging in images it uploads each image twice or more depending on how many times you trigger the modal.
@carakas

This comment has been minimized.

Copy link
Member

carakas commented Oct 3, 2019

Nice catch

@carakas carakas added this to the 5.6.3 milestone Oct 3, 2019
@carakas
carakas approved these changes Oct 3, 2019
@carakas carakas merged commit 0468bcc into forkcms:master Oct 3, 2019
3 checks passed
3 checks passed
Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@carakas carakas modified the milestones: 5.6.3, 5.7.0 Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.