Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Github issue & PR templates #2905

Merged
merged 2 commits into from Sep 25, 2019

Conversation

@jessedobbelaere
Copy link
Contributor

jessedobbelaere commented Sep 18, 2019

Improvement

Q A
Improvement yes
RFC yes
BC Break no

Summary

Heavily inspired by Doctrine ORM's github setup:

image

I would like to introduce this in Fork CMS.
Something like:

  • 💥 Critical Bug
  • 🐞 Bug Report
  • Feature Request
  • Support Question
  • Report a security vulnerability

I left out "Enhancement" that we used to have, as reporting an Enhancement is almost identical to reporting a Feature Request

Same goes for PR templates...

Resolves the following issues

@jessedobbelaere jessedobbelaere force-pushed the improved-github-issue-templates branch from 19166c0 to 1a107da Sep 18, 2019
@jessedobbelaere jessedobbelaere changed the title Improve Github issue templates Improve Github issue & PR templates Sep 18, 2019
@jessedobbelaere jessedobbelaere force-pushed the improved-github-issue-templates branch from 1a107da to 0ce6d6c Sep 18, 2019
Signed-off-by: Jesse Dobbelaere <jesse@dobbelae.re>
@jessedobbelaere jessedobbelaere force-pushed the improved-github-issue-templates branch from 0ce6d6c to 57bd05f Sep 18, 2019
@carakas

This comment has been minimized.

Copy link
Member

carakas commented Sep 24, 2019

@jessedobbelaere can you also make pull request templates for bugfixes? Or is there a reason you didn't make those?

@jessedobbelaere

This comment has been minimized.

Copy link
Contributor Author

jessedobbelaere commented Sep 24, 2019

@carakas it's part of the "Improvement" PR template

You have a bugfix or improvement to make Fork CMS better? 🎁

Basically I looked at Doctrine, https://github.com/doctrine/orm/tree/master/.github/PULL_REQUEST_TEMPLATE

But maybe we should make it more obvious, change the name to Improvement/bugfix ? Or add a new template for bugfixes?

@carakas

This comment has been minimized.

Copy link
Member

carakas commented Sep 24, 2019

I would make it more obvious indeed 👍

@jessedobbelaere

This comment has been minimized.

Copy link
Contributor Author

jessedobbelaere commented Sep 24, 2019

Cool, I modified the title to "Bugfixes and Improvements

@carakas carakas merged commit a8db09c into master Sep 25, 2019
5 checks passed
5 checks passed
Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@carakas carakas added this to the 5.6.3 milestone Sep 25, 2019
@carakas carakas modified the milestones: 5.6.3, 5.7.0 Oct 3, 2019
@carakas carakas deleted the improved-github-issue-templates branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.