Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require ext-json in composer.json #2925

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@carakas
Copy link
Member

carakas commented Oct 9, 2019

Type

  • Enhancement

Pull request description

When implementing the JsonSerializable interface PhpStorm was giving warnings that ext-json wasn't required in composer.json

When implementing the JsonSerialize interface PhpStorm was giving warnings that ext-json wasn't required in composer.json
@carakas carakas added this to the 5.7.0 milestone Oct 9, 2019
@carakas carakas requested a review from forkcms/core-contributors Oct 9, 2019
@carakas carakas merged commit a54d289 into master Oct 10, 2019
5 checks passed
5 checks passed
Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@carakas carakas deleted the require-ext-json-in-composer.json branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.