Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env variables loading in test mode #2928

Merged

Conversation

@ohvitorino
Copy link
Contributor

ohvitorino commented Oct 10, 2019

Type

  • Non critical bugfix

Pull request description

This PR sets the values of FORK_ENV and FORK_DEBUG in the PHPUnit configuration.
The values of $_SERVER['APP_ENV] and $_SERVER['APP_DEBUG] are also set to the same value as $_SERVER['FORK_ENV] and $_SERVER['FORK_DEBUG] respectively. The Symfony kernel makes some initialisation decisions based on these variables.

@carakas carakas added this to the 5.7.0 milestone Oct 10, 2019
@ohvitorino

This comment has been minimized.

Copy link
Contributor Author

ohvitorino commented Oct 10, 2019

I just noticed loading .env.test is not correct. I'll have a look at this again, because it's not correct to always load the file.

@ohvitorino ohvitorino changed the title Fix env variables loading in test mode [WIP] Fix env variables loading in test mode Oct 10, 2019
@ohvitorino ohvitorino requested a review from carakas Oct 10, 2019
@ohvitorino ohvitorino force-pushed the ohvitorino:fix-env-variables-loading-in-test-mode branch from 12c81c9 to 8ad92ec Oct 10, 2019
@ohvitorino ohvitorino changed the title [WIP] Fix env variables loading in test mode Fix env variables loading in test mode Oct 10, 2019
@carakas carakas merged commit d0f6f2f into forkcms:master Oct 10, 2019
3 checks passed
3 checks passed
Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.