Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session timeout popup #2931

Merged
merged 1 commit into from Oct 14, 2019

Conversation

@jonasdekeukelaere
Copy link
Contributor

jonasdekeukelaere commented Oct 14, 2019

Type

  • Non critical bugfix

Pull request description

In #2858 the session timeout popup was added, but the session_timout variable is saved in the jsData (see https://github.com/forkcms/forkcms/pull/2858/files#diff-4fb0e3a8ed70071edbb74cdf222a7af6R224) not in jsBackend.

Jonas De Keukelaere
@carakas carakas added this to the 5.7.0 milestone Oct 14, 2019
@carakas

This comment has been minimized.

Copy link
Member

carakas commented Oct 14, 2019

nice catch :)

@carakas carakas merged commit d37f756 into forkcms:master Oct 14, 2019
3 checks passed
3 checks passed
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.