Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpcs so we can use static function as callback without it complaing (false positive) #2957

Conversation

@carakas
Copy link
Member

carakas commented Oct 24, 2019

Type

  • Non critical bugfix

Pull request description

Fix getting code style errors like below when using a static function as a callback

FILE: ...s/build/justcarakas/forkcms/src/Backend/Form/Type/EditorType.php

----------------------------------------------------------------------

FOUND 8 ERRORS AFFECTING 8 LINES

----------------------------------------------------------------------

 65 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found

    |       |     12

 66 | ERROR | [x] Line indented incorrectly; expected 12 spaces,

    |       |     found 16

 68 | ERROR | [x] Line indented incorrectly; expected 12 spaces,

    |       |     found 16

 72 | ERROR | [x] Line indented incorrectly; expected 12 spaces,

    |       |     found 24

 74 | ERROR | [x] Line indented incorrectly; expected 12 spaces,

    |       |     found 24

 80 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found

    |       |     12

 86 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found

    |       |     12

 88 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found

    |       |     12

----------------------------------------------------------------------

PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY

----------------------------------------------------------------------
…plaing (false positive)
@carakas carakas added this to the 5.7.1 milestone Oct 24, 2019
@carakas carakas requested a review from forkcms/core-contributors Oct 24, 2019
@carakas carakas added the DX label Oct 24, 2019
Copy link

ohvitorino left a comment

LGTM

@carakas carakas merged commit 0a28763 into forkcms:master Oct 29, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@carakas carakas deleted the justcarakas:fix-phpcs-complaining-about-static-callbacks branch Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.