Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Make medialibrary modal scrollable #2960

Merged

Conversation

@jessedobbelaere
Copy link
Contributor

jessedobbelaere commented Oct 26, 2019

Type

  • Non critical bugfix

Resolves the following issues

Pull request description

When you create a media gallery and upload a bunch of files, the modal becomes bigger than the screen and does not allow for scrolling towards the Save button.

Before

before

After

after

@ohvitorino ohvitorino requested review from jeroendesloovere and carakas Oct 26, 2019
@carakas carakas requested review from Katrienvh and mathiashelin Oct 26, 2019
@carakas

This comment has been minimized.

Copy link
Member

carakas commented Oct 26, 2019

Love it, just checking with some frontenders if this is the correct way to fix this bug

@carakas carakas added this to the 5.7.1 milestone Nov 7, 2019
@carakas carakas merged commit ef8baf8 into forkcms:master Nov 7, 2019
3 checks passed
3 checks passed
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.