Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow get parameters to be set when creating an action for the DeleteType #2973

Merged
merged 2 commits into from Mar 3, 2020

Conversation

@StijnVrolijk
Copy link
Contributor

StijnVrolijk commented Nov 12, 2019

Type

  • Feature

Pull request description

While I was working on a feature in a project, the delete action my DeleteType was POSTing to didn't know what to redirect to after performing the delete but the action where I created the DeleteType did! By allowing the GET parameters of the action in the DeleteType to be set I was able to send a queryString parameter along to the Delete action. This allowed me to have the Edit action tell the Delete action where to redirect to, useful stuff!

This could be used for a multitude of other things as well.

@StijnVrolijk StijnVrolijk added this to the 5.8.0 milestone Nov 12, 2019
@StijnVrolijk StijnVrolijk requested a review from forkcms/backenders Nov 12, 2019
@ohvitorino

This comment has been minimized.

Copy link

ohvitorino commented Nov 19, 2019

@StijnVrolijk any chance we can document this somewhere? get_parameters doesn't really give much context to what it does.

@carakas

This comment has been minimized.

Copy link
Member

carakas commented Mar 3, 2020

@ohvitorino fixed in a8b1a81

@carakas carakas merged commit 824d804 into master Mar 3, 2020
4 of 5 checks passed
4 of 5 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@carakas carakas deleted the delete-type-querystring branch Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.