Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cropping for images with height lower than requested folder height #2997

Merged
merged 1 commit into from Dec 5, 2019

Conversation

@dreadnip
Copy link
Contributor

dreadnip commented Dec 4, 2019

Type

  • Non critical bugfix

Pull request description

This commit fixes thumbnail generation for images that have a base height lower than what is requested for that folder.

Before:
oeps

After:
beter

@ohvitorino

This comment has been minimized.

Copy link

ohvitorino commented Dec 4, 2019

@dreadnip can you add a pull request description? Thx

@carakas carakas added this to the 5.7.1 milestone Dec 4, 2019
@carakas
carakas approved these changes Dec 4, 2019
@ohvitorino ohvitorino requested review from ohvitorino and removed request for ohvitorino Dec 4, 2019
@carakas carakas merged commit e9de6c3 into forkcms:master Dec 5, 2019
3 checks passed
3 checks passed
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.