Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix page update error for an array offset on boolean value #3031

Merged
merged 1 commit into from Mar 3, 2020
Merged

Fix page update error for an array offset on boolean value #3031

merged 1 commit into from Mar 3, 2020

Conversation

jessedobbelaere
Copy link
Member

Type

  • Non critical bugfix

Resolves the following issues

image

Pull request description

Stumbled upon this error in a personal project. It happens when I edit a page in the root ($parentId is 0) and click the Save button.

Adding some hardening in case the self::get method above returns a false boolean value.

@carakas carakas added this to the 5.7.2 milestone Feb 6, 2020
@carakas carakas merged commit f1efd80 into forkcms:master Mar 3, 2020
@carakas carakas modified the milestones: 5.7.2, 5.8.0 Mar 3, 2020
@jessedobbelaere jessedobbelaere deleted the hardening-array-offset-on-bool branch July 19, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carakas carakas carakas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jessedobbelaere @carakas