Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page update error for an array offset on boolean value #3031

Merged

Conversation

@jessedobbelaere
Copy link
Contributor

jessedobbelaere commented Feb 6, 2020

Type

  • Non critical bugfix

Resolves the following issues

image

Pull request description

Stumbled upon this error in a personal project. It happens when I edit a page in the root ($parentId is 0) and click the Save button.

Adding some hardening in case the self::get method above returns a false boolean value.

@carakas
carakas approved these changes Feb 6, 2020
@carakas carakas added this to the 5.7.2 milestone Feb 6, 2020
@carakas carakas merged commit f1efd80 into forkcms:master Mar 3, 2020
4 checks passed
4 checks passed
Scrutinizer No new issues
Details
TypoCheck No typos found
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@carakas carakas modified the milestones: 5.7.2, 5.8.0 Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.