Make privacy consent dialog scrollable on mobile #3507
Conversation
Codecov ReportBase: 27.87% // Head: 27.86% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3507 +/- ##
============================================
- Coverage 27.87% 27.86% -0.02%
Complexity 8150 8150
============================================
Files 575 575
Lines 30706 30706
============================================
- Hits 8560 8556 -4
- Misses 22146 22150 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| overflow: initial; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
you need to add a newline at the end of your file here
| @@ -1,6 +1,6 @@ | |||
| {% include "Core/Layout/Templates/Head.html.twig" %} | |||
|
|
|||
| <body class="{{ LANGUAGE }}" itemscope itemtype="http://schema.org/WebPage"> | |||
| <body class="{{ LANGUAGE }} {% if not privacyConsentDialogHide %}modal-open{% endif %}" itemscope itemtype="http://schema.org/WebPage"> | |||
There was a problem hiding this comment.
can you explain why you have the class modal-open here? if it has to do with javascript you should use a data attribute. On top of that I'm not really a fan of having to add something there in the templates since that should be handled by the js itself
There was a problem hiding this comment.
To block the body from scrolling when the modal is open and scrollable. This way the class is only added when the consent dialog is visible. The consent dialog html is always rendered and just set to display: none when it doesn't need to be shown, so the element is always there.
I can change it so the modal html is only added when privacyConsentDialogHide = false and add the class to the body with js instead if you prefer.
| @@ -1,6 +1,6 @@ | |||
| {% include "Core/Layout/Templates/Head.html.twig" %} | |||
|
|
|||
| <body class="{{ LANGUAGE }}" itemscope itemtype="http://schema.org/WebPage"> | |||
| <body class="{{ LANGUAGE }} {% if not privacyConsentDialogHide %}modal-open{% endif %}" itemscope itemtype="http://schema.org/WebPage"> | |||
|
@carakas changes made as requested, can you check again please |
|
@carakas changes made as requested, can you check again please |
|
@daphneslootmans sorry for the delay, I was out for almost the whole month of September because of Covid |
Type
Pull request description
Make the privacy consent dialog scrollable on mobile