Skip to content

Make the old session clean-up method timezone aware #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2022

Conversation

sanderdlm
Copy link
Contributor

Type

  • Non critical bugfix

Resolves the following issues

/

Pull request description

This fixes a bug where the database timezone would be different from
UTC, and the date inserted into the database would be incorrectly removed
by the NOW() check.

Sander De la Marche added 2 commits May 5, 2022 12:06
This fixes a bug where the database timezone would be different from
UTC, and the date inserted into the database would be incorrectly removed
by the NOW() check.
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #3511 (5bd1cbc) into master (9e95d69) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #3511   +/-   ##
=========================================
  Coverage     27.87%   27.87%           
  Complexity     8150     8150           
=========================================
  Files           575      575           
  Lines         30705    30706    +1     
=========================================
+ Hits           8559     8560    +1     
  Misses        22146    22146           
Flag Coverage Δ
functional 23.78% <100.00%> (+<0.01%) ⬆️
installer 3.84% <0.00%> (-0.01%) ⬇️
unit 7.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Backend/Core/Engine/Authentication.php 90.44% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e95d69...5bd1cbc. Read the comment docs.

@carakas carakas added this to the 5.11.2 milestone May 5, 2022
@carakas carakas merged commit bd6bcd3 into forkcms:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants