Skip to content

Move the apple touch icon to the theme #3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

bjorvack
Copy link
Contributor

@bjorvack bjorvack commented May 9, 2022

Type

  • Enhancement

Pull request description

Use the apple-touch-icon of the theme instead of a hardcoded path

@bjorvack bjorvack requested a review from a team as a code owner May 9, 2022 08:33
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #3512 (1590ec0) into master (bd6bcd3) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master    #3512   +/-   ##
=========================================
  Coverage     27.87%   27.88%           
- Complexity     8150     8151    +1     
=========================================
  Files           575      575           
  Lines         30706    30714    +8     
=========================================
+ Hits           8560     8565    +5     
- Misses        22146    22149    +3     
Flag Coverage Δ
functional 23.79% <66.66%> (+0.01%) ⬆️
installer 3.84% <0.00%> (-0.01%) ⬇️
unit 7.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Common/Core/Twig/BaseTwigTemplate.php 73.68% <66.66%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6bcd3...1590ec0. Read the comment docs.

@carakas
Copy link
Member

carakas commented May 18, 2022

Is not backwards compatible, if somebody updates Fork and they use a theme that doesn't have an icon there it won't work.
You could implement it in a BC way by passing the path from the action and checking in the action if there is an icon in the active theme or otherwise fall back to the one in the root

@carakas carakas closed this May 18, 2022
@carakas carakas reopened this May 18, 2022
@carakas carakas merged commit 459606f into forkcms:master Nov 1, 2022
@carakas carakas added this to the 5.11.2 milestone Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants