Skip to content

Fix redirecting in parseWidget #3513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2022

Conversation

alessandrocraeye
Copy link
Contributor

Type

  • Non critical bugfix

Resolves the following issues

/

Pull request description

This fixes the following error that occurs when submitting a form that's added via parseWidget:
Type error: Argument 2 passed to Twig\Error\Error::__construct() must be of the type int, null given

Set lineno to the default value -1 (to enable its automatic guessing)

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #3513 (a2e23cc) into master (bd6bcd3) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #3513   +/-   ##
=========================================
  Coverage     27.87%   27.87%           
  Complexity     8150     8150           
=========================================
  Files           575      575           
  Lines         30706    30706           
=========================================
  Hits           8560     8560           
  Misses        22146    22146           
Flag Coverage Δ
functional 23.78% <0.00%> (ø)
installer 3.84% <0.00%> (ø)
unit 7.69% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Frontend/Core/Engine/TemplateModifiers.php 9.80% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6bcd3...a2e23cc. Read the comment docs.

@carakas carakas merged commit a2c3644 into forkcms:master May 18, 2022
@carakas carakas added this to the 5.11.2 milestone May 18, 2022
@carakas
Copy link
Member

carakas commented May 18, 2022

Thanks, sorry for the late merge, must have missed the notification

@alessandrocraeye alessandrocraeye deleted the fix-twig-error-type-error branch May 19, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants