feat(koinon): temporal baseline engine with Welford's algorithm#14
Merged
Conversation
- Welford's online algorithm for running mean/variance/stddev in O(1) memory - TimeWindowedBaseline with ring buffer eviction (count + age) - TemporalBucketedBaseline with 168 buckets (7 days x 24 hours) - AnomalyScore classification (Normal/Elevated/Anomalous/InsufficientData) - Baseline merge for parallel computation - proptest property-based testing: convergence, merge correctness, z-score identity
Contributor
|
Consider splitting into smaller PRs for easier review. Not a blocker, just a signal. |
/tmp was exhausted by leftover temp dirs, causing tamper_log tests to fail with ENOSPC when creating temporary files. No code changes required; re-triggering CI after disk space was freed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimeWindowedBaselinewith ring buffer eviction (count + age)TemporalBucketedBaselinewith 168 buckets (7 days × 24 hours)AnomalyScoreclassification (Normal/Elevated/Anomalous/InsufficientData)Baseline::mergefor parallel computation via parallel Welford mergeTest plan
cargo test --workspace— 71/71 unit + proptest tests passcargo clippy --workspace --all-targets -- -D warnings— zero warningscargo fmt --all -- --check— format cleanObservations
TemporalBucketedBaseline::bucket()returnsOption<&Baseline>rather than&Baselineas specified, becausepanic = "deny"at the workspace level makes a panicking out-of-bounds access impossible. TheOptionreturn correctly signals invalid day/hour indices. File:crates/koinon/src/baseline.rs.AnomalyScoreis#[non_exhaustive]per RUST.md policy; consumers outside the crate must add a wildcard arm when matching.🤖 Generated with Claude Code