Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Loosen dependencies #10

Closed
isaacs opened this Issue Sep 4, 2012 · 2 comments

Comments

Projects
None yet
2 participants

isaacs commented Sep 4, 2012

This package depends on mime@1.2.2. However, the mime package frequently updates the patch number to pull in additional mime types, without changing the API. (At this time, it's at v1.2.7.)

While it makes sense to lock down a deployed application or website, perhaps even using git or npm shrinkwrap, a reusable library like form-data should be a bit more flexible.

Consider switching the dependency to ~1.2.7 so that users can add additional mime types without having to bundle and patch form-data.

Similarly, the async project is extremely stable at this point. The API has been consistent for about a year, and only minor bug fixes have been applied. The last few versions have fixed some inconsistencies between null/undefined usage, added a bunch of tests, and cleaned up the readme. Consider using ~0.1.22 to be able to work with these changes.

@isaacs isaacs referenced this issue in request/request Sep 4, 2012

Closed

Bundled dependencies breaking shrinkwrap #313

@isaacs isaacs added a commit to isaacs/request that referenced this issue Sep 4, 2012

@isaacs isaacs Declare dependencies more sanely
Workaround for #313
Related to form-data/form-data#10
7725b23

@alexindigo alexindigo was assigned Sep 5, 2012

Owner

alexindigo commented Sep 5, 2012

Sounds logical to me.

@alexindigo alexindigo added a commit to alexindigo/form-data that referenced this issue Sep 5, 2012

@alexindigo alexindigo Fix for #10. bab70b9
Owner

alexindigo commented Sep 5, 2012

Fixed in bab70b9.
Hi from SummerCamp :)

@alexindigo alexindigo added a commit that referenced this issue Sep 5, 2012

@alexindigo alexindigo Merge pull request #11 from alexindigo/master
Fix for #10
0937ea0

@alexindigo alexindigo closed this Sep 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment