Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added support for https destination, http-response and mikeal's request streams. #7

Merged
merged 4 commits into from Aug 4, 2012

Conversation

Projects
None yet
2 participants
Owner

alexindigo commented Jul 27, 2012

Use cases:

  • https destination: upload photos to api.500px.com
  • remote file streams (http-response, mikeal's request): Upload photos from Flickr to 500px.com or vice versa.
Added support for https destination, http-response and mikeal's reque…
…st streams.

Use cases:

- https destination: upload photos to api.500px.com

- remote file streams (http-response, mikeal's request): Upload photos from Flickr to 500px.com or vice versa.
Owner

alexindigo commented Jul 27, 2012

And I made workaround for tests (incoming form parsing) since formidable is broken.

Contributor

felixge commented Jul 30, 2012

And I made workaround for tests (incoming form parsing) since formidable is broken.

What's broken in formidable?

I'm not using this module at the moment, so I'm happy to merge this patch (and also give you npm access to publish versions if you like). Two things so:

  • Could you add an example for your features to the Readme?
  • Your new test test-http-respone.js seems have a typo in the filename (missing s).
Owner

alexindigo commented Jul 30, 2012

It failed on form.parse(req); in original checkout,
and when I went to formidable github page it showed that travis test broken,
on the travis page it showed it's broken for node 0.4 and node 0.6,
so I realized you guys up to something. :)

And just added workaround for the tests here.
(Going to revert it back when formidable is back to normal).

Thanx, fixed the typo.

Take a look at Readme if it's ok, you you want something more elaborated.

I'm heavily relaying on this module in my project,
so I don't mind to publish updates to npm.

Thank you.

coding style, braces go on the same line

Contributor

felixge commented Aug 2, 2012

I added another comment, and also made a you a collaborator on the GitHub project (so you can merge this yourself if you're happy with this).

If you give me your npm user name, I'll also give you npm publish permissions.

Owner

alexindigo commented Aug 4, 2012

I fixed styling. Going to merge it.

My npm name: alexindigo.

Thanx.

alexindigo added a commit that referenced this pull request Aug 4, 2012

Merge pull request #7 from alexindigo/master
Added support for https destination, http-response and mikeal's request streams.

@alexindigo alexindigo merged commit 3832297 into form-data:master Aug 4, 2012

Contributor

felixge commented Aug 5, 2012

Thanks. Added you as an npm contributor as well. Feel free to publish versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment