From c9d485d2c5cc61be30096a73232b0e924bb532bf Mon Sep 17 00:00:00 2001 From: Josh Davies Date: Thu, 10 Jul 2025 10:27:39 +0100 Subject: [PATCH] test: further fix the timeout test to avoid false failures FORM can terminate on timeout without printing an error message, with exit status != 0, so assert succeeded? || runtime_error? is not sufficient to catch this. Just don't assert anything. Hitting the test suite timeout still results in a failed test. --- check/features.frm | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/check/features.frm b/check/features.frm index fc558414..c585c52f 100644 --- a/check/features.frm +++ b/check/features.frm @@ -303,12 +303,13 @@ assert succeeded? #timeoutafter 0 .end #require unix? -# ParFORM may terminate without printing the error message, -# depending on the MPI environment. +# Sometimes, FORM can terminate without printing the error message, so don't +# assert anything. We only test whether this hits the test suite timeout limit, +# or not. TODO in principle this can be considered to be a bug, to be looked at +# in the future. +# For parform, there is no attempt to ensure the master process recieves SIGALRM +# and not the workers. #pend_if mpi? -# Sometimes, FORM will terminate after 1s without a runtime error. -# TODO: this should be considered a bug. -assert succeeded? || runtime_error? *--#] TimeoutAfter_2 : *--#[ dedup : * Test deduplication