Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry dropping slot on errors #13

Merged
merged 1 commit into from Jan 27, 2020
Merged

Conversation

english
Copy link
Contributor

@english english commented Jan 24, 2020

Postgres will error when attempting to drop a slot while it's actively
being used. This can present a problem when a single Terraform plan will
drop the replication slot as well as stopping the service using it. In that
scenario we'd like to keep trying to drop the slot until the service has come
down and the slot becomes inactive.

See terraform docs for how to override the default configuration of
retrying up to one minute.

Postgres will error when attempting to drop a slot while it's actively
being used. This can present a problem when a single Terraform plan will
drop the replication slot as well as stopping the service using it and
thus make the slot inactive.In that scenario we'd like to keep trying to
drop the slot until the service has come down.

See [terraform docs][1] for how to override the default configuration of
retrying up to one minute.

[1]: https://www.terraform.io/docs/configuration/resources.html#operation-timeouts
@english english requested a review from sam-io January 24, 2020 15:59
@english english merged commit af11654 into master Jan 27, 2020
@english english deleted the english-retry-dropping-slot branch January 27, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants