Skip to content

fix(payments/generic): EN-392 fixes nil deref if no http resp #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

fix(payments/generic): EN-392 fixes nil deref if no http resp #1965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84cc95a
fix(payments/generic): EN-392 fixes nil deref if no http resp
Quentin-David-24 Nov 5, 2025
a4e18a7
Add unreachable server error and add it as a retryable error
Quentin-David-24 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions components/payments/cmd/connectors/internal/connectors/generic/client/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,16 @@ import (
)

var (
ErrStatusCodeClientError = errors.New("client error")
ErrStatusCodeServerError = errors.New("server error")
ErrStatusCodeClientError = errors.New("client error")
ErrStatusCodeServerError = errors.New("server error")
ErrUnreachableServerError = errors.New("unreachable server")
)

func wrapError(err error, resp *http.Response) error {
if resp == nil {
return fmt.Errorf("%w: %w", err, ErrUnreachableServerError)
}

statusCode := resp.StatusCode

if statusCode >= http.StatusBadRequest && statusCode < http.StatusInternalServerError {
Expand Down
2 changes: 1 addition & 1 deletion components/payments/cmd/connectors/internal/connectors/generic/task_fetch_accounts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func ingestAccounts(
for page := 1; ; page++ {
accounts, err := c.ListAccounts(ctx, int64(page), pageSize)
if err != nil {
if errors.Is(err, client.ErrStatusCodeServerError) {
if errors.Is(err, client.ErrStatusCodeServerError) || errors.Is(err, client.ErrUnreachableServerError) {
return fmt.Errorf("%w: %w", task.ErrRetryable, err)
}
return err
Expand Down
2 changes: 1 addition & 1 deletion components/payments/cmd/connectors/internal/connectors/generic/task_fetch_balances.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func taskFetchBalances(c *client.Client, config *Config, accountID string) task.
// retryable error already handled by the client
otel.RecordError(span, err)

if errors.Is(err, client.ErrStatusCodeServerError) {
if errors.Is(err, client.ErrStatusCodeServerError) || errors.Is(err, client.ErrUnreachableServerError) {
return fmt.Errorf("%w: %w", task.ErrRetryable, err)
}

Expand Down
2 changes: 1 addition & 1 deletion components/payments/cmd/connectors/internal/connectors/generic/task_fetch_beneficiaries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func ingestBeneficiaries(
for page := 1; ; page++ {
beneficiaries, err := c.ListBeneficiaries(ctx, int64(page), pageSize, state.LastCreatedAt)
if err != nil {
if errors.Is(err, client.ErrStatusCodeServerError) {
if errors.Is(err, client.ErrStatusCodeServerError) || errors.Is(err, client.ErrUnreachableServerError) {
return fetchBeneficiariesState{}, fmt.Errorf("%w: %w", task.ErrRetryable, err)
}

Expand Down
2 changes: 1 addition & 1 deletion components/payments/cmd/connectors/internal/connectors/generic/task_fetch_transactions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func ingestTransactions(
for page := 1; ; page++ {
transactions, err := c.ListTransactions(ctx, int64(page), pageSize, state.LastUpdatedAt)
if err != nil {
if errors.Is(err, client.ErrStatusCodeServerError) {
if errors.Is(err, client.ErrStatusCodeServerError) || errors.Is(err, client.ErrUnreachableServerError) {
return fetchTransactionsState{}, fmt.Errorf("%w: %w", task.ErrRetryable, err)
}

Expand Down