Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve original submit button #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richard-ejem
Copy link

Currently, the button clicked to submit the form is not preserved and therefore not included in the request sent to server, because this package calls event.preventDefault, then, if the form is valid, sends form.submit(). This PR fixes the problem.

@richard-ejem richard-ejem force-pushed the fix-sending-submit-button branch 2 times, most recently from 4b74b55 to dceecf4 Compare February 6, 2018 13:27
@66Ton99
Copy link
Collaborator

66Ton99 commented Sep 25, 2020

Pleas look on the tests they are falling on you realization.

@richard-ejem
Copy link
Author

Pleas look on the tests they are falling on you realization.

Thanks for the feedback, but honestly I did this 3 years ago, now I don't even do PHP much anymore and this PR is completely out of my interest now, so I'm not willing to spend any more time with it. I don't even know if the issue is still present in latest version. If you look at the test results, it seems the test setup is completely broken and it is obviously nothing that could be caused by the PR. It is very likely that if the PR is still valid, just rebasing on current master where tests work will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants