Encode checkbox value to prevent XSS attack #584
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi,
The default behavior of Former is to use $_GET variables to populate the form fields, If I understood correctly.
This makes a XSS attack possible because checkbox are not escaping their values.
A similar fix was made here in 2014 for hidden inputs: 5859644
I had a hard time trying to use the right version for the tests, since there's no composer.lock, but when I got it right all tests passed.
Steps to reproduce:
{!! Former::checkbox('test') !!}Expected behavior:
What happens: