New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing ajax creation for non gold accounts #173

Merged
merged 3 commits into from Feb 10, 2018

Conversation

Projects
None yet
4 participants
@colevscode
Member

colevscode commented Feb 5, 2018

Changes proposed in this pull request:

  • Currently we're seeing a lot of spam come from ajax forms, since we must allow ajax to bypass the CAPTCHA. Unfortunately the most strait forward solution is to remove this capability.
  • This PR makes submitting AJAX forms a gold feature.
  • Existing forms will continue to work, even AJAX forms that have been created by non gold users.

Have you made sure to add:

  • Tests
  • Documentation
@fiatjaf

This comment has been minimized.

Contributor

fiatjaf commented Feb 5, 2018

Looks good to me.

@rohitdatta

This looks good, I'm ready to merge it.

@colevscode colevscode force-pushed the colevscode:gold-only-ajax branch from e0c9113 to 1fb7987 Feb 10, 2018

@colevscode colevscode merged commit d91088e into formspree:master Feb 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@andri

This comment has been minimized.

andri commented Mar 1, 2018

I'm pretty sure this did not work for all existing forms. I had three sites using your service and found out days later that my contact forms didn't work anymore.

It would have been nice to receive heads up before such crucial changes are made.

@rohitdatta

This comment has been minimized.

Member

rohitdatta commented Mar 1, 2018

@andri that definitely wasn't the intended behavior. We tested this prior to deployment to ensure that it would only affect new forms and decided not to send out a notification to avoid confusing existing users into thinking their forms would break. Please open a ticket and let us know the hosts and emails of the affected forms so we can investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment