Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta upgrade: final checklist #134

Closed
benkeen opened this issue Jan 21, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@benkeen
Copy link
Member

commented Jan 21, 2018

Checklist for completing the Form Tools 2 to 3 upgrade. All these tasks need to be complete before we can move the script into Beta and offer FT3 via the upgrade script.

Core

  • Accommodate database changes:
{prefix}forms table: add_submission_button_label now "blank"
{prefix}modules: remove is_premium column (if defined)
edit_submission_onload_resources has been updated for new codemirror paths
  • Confirm upgrade message appears on login page.
  • cache busting CSS/JS (all themes)
  • Core Field module? How to easily deprecate? May need a check in the FT Core.
  • System Check module - everything pass?
  • Show invalid FT2 modules on Modules page with instructions to upgrade.
  • update error reporting
  • review open bugs and get all the important ones resolved (e.g. the image formatting of the default theme's header!)
  • editing checkbox Smarty content had an error in it that the new Smarty parser chokes on. Need to update that field.

Modules

  • Arbitrary Settings
  • Client Audit
  • Custom Fields
  • Data Visualization
  • Export Manager
  • Extended Client Fields
  • File Upload Field
  • Form Backup
  • Form Builder
    Check this one over again in more detail + provide custom instructions for anything that may potentially melt.
  • Google Maps Field
  • Hello Database!
  • Hello Tabs!
  • Hello World!
  • Hooks Manager
  • Fiddly one. Hooks Manager will need a full mapping of old to new methods to properly upgrade.
  • IP Security Check
  • Javascript Error Logs
  • Pages
  • Report Builder
  • Submission Accounts
  • Submission History
  • Submission ID Manager
  • Submission Pre-Parser
  • Swift Mailer
  • System Check
  • Text Override
  • TinyMCE Field
    Needs work too. Check out the upgrade method stub for notes.

Upgrade script

  • prohibit upgrading to FT3 if ANY of the components aren't updated to the supported upgrade version (li.e. ast FT2-compatible version)
  • get back online

@benkeen benkeen added the Upgrading label Jan 21, 2018

@johnbleck3

This comment has been minimized.

Copy link

commented Jan 25, 2018

I just updated the core with the latest files.

I got an error
Warning: ucwords() expects exactly 1 parameter, 2 given in /var/www/forms.buffalonews.com/global/code/Modules.class.php on line 773

I changed the below for now on my installation so I can continue working on the forms.

$upper_case = ucwords($module_folder, "_");
to
$upper_case = ucwords($module_folder);

@benkeen

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2018

Hey @johnbleck3, ah drat. I misread the docs - that second param is only available as of 5.4.32 / 5.5.16. http://php.net/manual/en/function.ucwords.php.

I'll need to doctor this method to work on all versions of supported PHP - I'll create an issue. Thanks!

N.B. that fix you did will remove the error but will cause other problems - in certain scenarios modules won't be properly loaded. I'll patch up a few more bugs and release a new version of the core today.

EDIT: this has been fixed & I'll roll out a new version this weekend. Ooh - and note, be sure to only update your repo with the actual released core versions. master just contains the latest & greatest code, but I don't guarantee each commit to leave a functioning application. Sometimes when working on larger things it takes several days. So best to only download the releases.

@nelsondcosta23

This comment has been minimized.

Copy link

commented Feb 2, 2018

Almost everything is complete :)
This will be grateful for people like me. I have 2 FT2 with a lot of information.

@benkeen benkeen changed the title Upgrade checklist Beta upgrade: final checklist Feb 4, 2018

@benkeen benkeen closed this Feb 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.