Feature/export errors and symbols #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
||
| import { POWER } from './../math-trig.js' | ||
|
|
||
| /** |
There was a problem hiding this comment.
Can you add a little paragraph to explain the motivation of the whole file? Instead of the legacy doc block of each function.
/**
* Formula.js only
*
There was a problem hiding this comment.
Would you like me to add something like this to the top of the page:
/**
* Following functions are part of Formula.js only and not found in Excel.
* Purpose of these functions is to implement an Excel like behavior for fundamental math symbols such as +, -, /, *, etc.
*/
We can leave the individual doc blocks intact if that's ok since they provide intellisense to the IDEs?
There was a problem hiding this comment.
Perfect. Let's do it like that.
nicolashefti
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from #79, retroactively add symbol functions. Also re-export error functions which were left out during refactoring of v3.0.