This repository has been archived by the owner on Jun 5, 2023. It is now read-only.
kubernetes rule updated to address the latest vulnerabilities #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueandgold
reviewed
Sep 6, 2018
rules/ke_rules.yaml
Outdated
| @@ -61,13 +61,25 @@ rules: | |||
| check_serverconfig_valid_master_versions: false | |||
| allowed_nodepool_versions: | |||
| - major: '1.8' | |||
| minor: '12-gke.1' | |||
| minor: '10-gke.2' | |||
| operator: '=' | |||
There was a problem hiding this comment.
Can we do a >= operator here, so that it will capture 1.8.12-gke.3 and not repeat the major versions?
There was a problem hiding this comment.
Same with the ones below too.
There was a problem hiding this comment.
After clarifying this offline, can we just a comment here to explain the gap, so that it's easier to understand?
blueandgold
approved these changes
Sep 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2018-5390 describes a kernel-level networking vulnerability that increases the effectiveness of denial of service (DoS) attacks against vulnerable systems over TCP connections.
CVE-2018-5391 describes a kernel-level networking vulnerability that increases the effectiveness of denial of service (DoS) attacks against vulnerable systems over IP connections.