Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
@osandoval011 - re: CLA, you need to submit the commit with the email you have registered internally. This is documented at go/cla#googlers From bbbe906 Mon Sep 17 00:00:00 2001 |
Ran create inventory with cai and api with each of bigquery.metadataviewer and bigquery.dataviewer. All 4 produced 54 rows with identical data. I believe this is ready for merge. |
…bigquery.metadataViewer
bbbe906
to
c8c4a75
Compare
CLAs look good, thanks! |
I still see some errors in the travis run? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, and adding the screenshot to verify the permission changes.
Codecov Report
@@ Coverage Diff @@
## dev #2395 +/- ##
==========================================
- Coverage 88.57% 88.57% -0.01%
==========================================
Files 180 180
Lines 14120 14117 -3
==========================================
- Hits 12507 12504 -3
Misses 1613 1613
|
Fix #2366
bigquery.metadataViewer is least privilege necessary to facilitate Forseti actions that were previously permitted by the more permissive bigquer.dataViewer