Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fortio curl exit status is 0 despite error #653

Closed
ldemailly opened this issue Nov 12, 2022 · 0 comments · Fixed by #654
Closed

fortio curl exit status is 0 despite error #653

ldemailly opened this issue Nov 12, 2022 · 0 comments · Fixed by #654
Labels
bug

Comments

@ldemailly
Copy link
Member 

fortio curl err; echo $?
13:07:50 W http_client.go:152> Assuming http:// on missing scheme for 'err'
13:07:50 E network.go:386> Unable to lookup 'err' : lookup err: no such host
0
@ldemailly ldemailly added the bug label Nov 12, 2022
@ldemailly ldemailly mentioned this issue Nov 12, 2022
Merged
3 tasks
ldemailly added a commit that referenced this issue Nov 12, 2022
@ldemailly
fix #653: 1 status code on any error
efcdea0
ldemailly added a commit that referenced this issue Nov 12, 2022
@ldemailly
added test for #652, stepped on #653 while testing the test, added te…
860b2f9 
…st for that too (#654)

* added tests for #652, stepped on #652 while testing the test, added test for that as well

* fix #653: 1 status code on any error

* fix the test, timeout is 124 if we don't --preserve-status

* fix #652, also fix help that was missing udp-echo, prep for 1.18.4

* check for server args before starting servers. update modules

* cheers, no more gocyclo for main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added test for #652, stepped on #653 while testing the test, added test for that too fortio/fortio
1 participant
@ldemailly