New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support passing headers and timeout in jrpc calls #621
Conversation
Codecov ReportBase: 88.4% // Head: 88.4% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #621 +/- ##
========================================
+ Coverage 88.4% 88.4% +0.1%
========================================
Files 30 30
Lines 4289 4309 +20
========================================
+ Hits 3790 3810 +20
Misses 335 335
Partials 164 164
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically only a few nits/questions
Co-authored-by: Wiard van Rij <wiard@outlook.com>
fixes #619
sort of breaking api change, added some "jrpc.xxxxURL" backward compatible string url call points