Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support passing headers and timeout in jrpc calls #621

merged 8 commits into from Sep 7, 2022


Copy link

fixes #619

sort of breaking api change, added some "jrpc.xxxxURL" backward compatible string url call points

Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Base: 88.4% // Head: 88.4% // Increases project coverage by +0.1% 🎉

Coverage data is based on head (73c9268) compared to base (cbf33f7).
Patch coverage: 100.0% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #621     +/-   ##
+ Coverage    88.4%   88.4%   +0.1%     
  Files          30      30             
  Lines        4289    4309     +20     
+ Hits         3790    3810     +20     
  Misses        335     335             
  Partials      164     164             
Impacted Files Coverage Δ
fhttp/http_server.go 80.8% <ø> (ø)
jrpc/jrpcServer.go 100.0% <ø> (ø)
rapi/restHandler.go 87.0% <ø> (ø)
fhttp/http_client.go 84.2% <100.0%> (ø)
fhttp/http_forwarder.go 90.2% <100.0%> (ø)
jrpc/jrpcClient.go 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@wiardvanrij wiardvanrij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically only a few nits/questions

jrpc/jrpcClient.go Show resolved Hide resolved
jrpc/jrpcClient.go Outdated Show resolved Hide resolved
jrpc/jrpcClient.go Show resolved Hide resolved
jrpc/jrpcClient.go Show resolved Hide resolved
@ldemailly ldemailly merged commit 83ce661 into master Sep 7, 2022
9 checks passed
@ldemailly ldemailly deleted the jrpc_headers branch September 7, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

jgrpc needs to let caller add optional headers
2 participants