Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty body to be valid for jrpc.HandleCall/Deserialize; allow method override in client #623

merged 2 commits into from Sep 13, 2022


Copy link

Allow empty body to be valid for HandleCall/Deserialize; allow call/send/... methods to be overridden

Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 88.4% // Head: 88.4% // Decreases project coverage by -0.1% ⚠️

Coverage data is based on head (dfe8ce9) compared to base (0d61b4f).
Patch coverage: 100.0% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #623     +/-   ##
- Coverage    88.4%   88.4%   -0.1%     
  Files          30      30             
  Lines        4313    4320      +7     
+ Hits         3814    3818      +4     
- Misses        335     337      +2     
- Partials      164     165      +1     
Impacted Files Coverage Δ
jrpc/jrpcServer.go 100.0% <ø> (ø)
jrpc/jrpcClient.go 100.0% <100.0%> (ø)
dflag/configmap/updater.go 78.8% <0.0%> (-2.9%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ldemailly ldemailly merged commit 0fa8982 into master Sep 13, 2022
8 of 9 checks passed
@ldemailly ldemailly deleted the allow_empty_jrpc_body_in_POST branch September 13, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants