Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for slice/array returned from jrpc calls as well as a cleaner shortcut: jrpc.GetArray() #634

merged 4 commits into from Oct 24, 2022


Copy link

Add tests for slice/array returned from jrpc calls as well as a cleaner shortcut/example of use: jrpc.GetArray()

Also fix #633 incidentally

Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 88.5% // Head: 88.5% // Increases project coverage by +0.0% 🎉

Coverage data is based on head (3e8550b) compared to base (fbcebcb).
Patch coverage: 100.0% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #634   +/-   ##
  Coverage    88.5%   88.5%           
  Files          30      30           
  Lines        4345    4350    +5     
+ Hits         3844    3849    +5     
  Misses        336     336           
  Partials      165     165           
Impacted Files Coverage Δ
jrpc/jrpcClient.go 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@wiardvanrij wiardvanrij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :D

jrpc/jrpc_test.go Show resolved Hide resolved
@ldemailly ldemailly merged commit d2a2d42 into master Oct 24, 2022
9 checks passed
@ldemailly ldemailly deleted the jrpc_slices branch October 24, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

jrpc - make cleaner error message
2 participants