Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeql v2 and a lot of github actions update, sha pinning in dockerfile etc #647

merged 9 commits into from Nov 6, 2022


Copy link

@ldemailly ldemailly commented Nov 5, 2022

changed comment v1->v2 and reran

pin-github-action .github/workflows/codeql-analysis.yml

fixes #642

Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 88.5% // Head: 88.5% // Decreases project coverage by -0.0% ⚠️

Coverage data is based on head (6275e3b) compared to base (9f500ab).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #647     +/-   ##
- Coverage    88.5%   88.5%   -0.0%     
  Files          30      30             
  Lines        4350    4350             
- Hits         3849    3848      -1     
- Misses        336     337      +1     
  Partials      165     165             
Impacted Files Coverage Δ
dflag/configmap/updater.go 80.8% <0.0%> (-1.0%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

why not just @v2 ? I'm also trying to understand the other specific sha pins.

Copy link
Member Author

check the score card at (but basically pinned is somewhat safer)

@ldemailly ldemailly changed the title codeql v2 codeql v2 and a lot of github actions update, sha pinning in dockerfile etc Nov 6, 2022
@ldemailly ldemailly merged commit 224f9c7 into master Nov 6, 2022
11 of 12 checks passed
@ldemailly ldemailly deleted the dep_update branch November 6, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

CodeQL Action v1 will be deprecated
2 participants