Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support User-Agent change and deletion from -H, simplify UI for headers #649

merged 6 commits into from Nov 7, 2022


Copy link

support User-Agent change and deletion from -H, simplify UI for headers to be extra headers only.

fixes #648

Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Base: 88.4% // Head: 88.4% // Increases project coverage by +0.0% 🎉

Coverage data is based on head (7901945) compared to base (224f9c7).
Patch coverage: 89.5% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #649   +/-   ##
  Coverage    88.4%   88.4%           
  Files          30      30           
  Lines        4350    4361   +11     
+ Hits         3847    3857   +10     
- Misses        337     338    +1     
  Partials      166     166           
Impacted Files Coverage Δ
rapi/restHandler.go 87.0% <ø> (-<0.1%) ⬇️
fhttp/http_client.go 84.3% <85.7%> (-0.1%) ⬇️
fhttp/http_forwarder.go 90.3% <100.0%> (ø)
fhttp/http_utils.go 95.6% <100.0%> (+<0.1%) ⬆️
dflag/configmap/updater.go 80.8% <0.0%> (-1.0%) ⬇️
fnet/network.go 90.1% <0.0%> (+0.5%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…for go client feature of setting User-Agent when not present
…erentiate between delete and emit empty for stdclient and User-Agent:. fixed debug output as well for the stdclient request.
Copy link

@wiardvanrij wiardvanrij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, funny how something small ends up into this :)

The only nit I have, is that technically if you would enforce a linter on it (comments), it's going to say something about the style. It should start with a capital and end with a dot .. But I'll leave it up to you if you want to start making that the default/standard to make the comments more uniform.

Copy link
Member Author

While I totally agree it is useful for documentation to have proper complete sentences, I dont think making complete sentences of local comments in test files or middle of code is useful. even cosmetically I think it detracts from their purpose (and more importantly puts incentive to not comment)

@ldemailly ldemailly merged commit 08dd2ac into master Nov 7, 2022
9 checks passed
@ldemailly ldemailly deleted the fix_ua branch November 7, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

can't set user-agent from command line
4 participants