New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support User-Agent change and deletion from -H, simplify UI for headers #649
Conversation
…rs to be extra headers only. fixes #648
Codecov ReportBase: 88.4% // Head: 88.4% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #649 +/- ##
======================================
Coverage 88.4% 88.4%
======================================
Files 30 30
Lines 4350 4361 +11
======================================
+ Hits 3847 3857 +10
- Misses 337 338 +1
Partials 166 166
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
|
…for go client feature of setting User-Agent when not present
…erentiate between delete and emit empty for stdclient and User-Agent:. fixed debug output as well for the stdclient request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good, funny how something small ends up into this :)
The only nit I have, is that technically if you would enforce a linter on it (comments), it's going to say something about the style. It should start with a capital and end with a dot .
. But I'll leave it up to you if you want to start making that the default/standard to make the comments more uniform.
While I totally agree it is useful for documentation to have proper complete sentences, I dont think making complete sentences of local comments in test files or middle of code is useful. even cosmetically I think it detracts from their purpose (and more importantly puts incentive to not comment) |
support User-Agent change and deletion from -H, simplify UI for headers to be extra headers only.
fixes #648