Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test for #652, stepped on #653 while testing the test, added test for that too #654

merged 6 commits into from Nov 12, 2022


Copy link

@ldemailly ldemailly commented Nov 12, 2022

Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Base: 88.5% // Head: 88.5% // No change to project coverage 👍

Coverage data is based on head (74de56a) compared to base (08dd2ac).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #654   +/-   ##
  Coverage    88.5%   88.5%           
  Files          30      30           
  Lines        4361    4361           
  Hits         3858    3858           
  Misses        337     337           
  Partials      166     166           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@asha-oss asha-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@ldemailly ldemailly merged commit 860b2f9 into master Nov 12, 2022
9 checks passed
@ldemailly ldemailly deleted the fix_missing_err_extra_args branch November 12, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

fortio curl exit status is 0 despite error fortio server should error on extra non flag arguments
2 participants