just allow . on new subcommand instead of changing canonical path pro… #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the change is made such that if the canonical name is subsequently returned by canon_path(3f) the code will still work, the change of "." to the current directory will just become redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous change to make canon_path(3f) technically more correct or like realpath(3c) exposed other uses of the routine not compatible with a real realpath(3c) behavior, so making simple change to special-case the "." pathname or a null pathname in the
newsubcommand so thatfpm new --backfill fpm new . --backfillwork; as currently the --backfill option requires a pathname including at least the base directory name, which is non-intuitive.