Update module output directory command for flang-new/f18#645
Merged
awvwgk merged 1 commit intofortran-lang:mainfrom Jan 10, 2022
Merged
Update module output directory command for flang-new/f18#645awvwgk merged 1 commit intofortran-lang:mainfrom
awvwgk merged 1 commit intofortran-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the new LLVM flang driver is mistaken for the classic flang driver and therefore it fails with
With this patch we can run the
flang-newdriver and get the expected error due to missing code generation:The
f18driver is less picky and takes-J,-moduleand-module-dirto specify the module output directory, I went with the latter since this is apparently in line withflang-new.Note that there is
flangin LLVM flang which is not the classic flang compiler, but presumably an internal component for theflang-new/f18drivers (or maybe the other way round?). We will currently detect it as classic flang and fail withBut I can't figure out how I'm supposed to correctly use it anyway.