Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore hidden source files #654

Merged
merged 3 commits into from
Feb 12, 2022
Merged

Ignore hidden source files #654

merged 3 commits into from
Feb 12, 2022

Conversation

noisegul
Copy link
Contributor

Addresses #649
This change does not handle hidden directories, only files.

@awvwgk awvwgk self-requested a review January 28, 2022 07:15
awvwgk
awvwgk approved these changes Feb 6, 2022
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. I'm fine with merging this as is.

Only one thing to discuss is how hidden directories should be handled, src/.dir/file.f90 will still be included with our current approach.

LKedward
LKedward approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this @noisegul - this LGTM 👍

@awvwgk awvwgk merged commit 57b5636 into fortran-lang:main Feb 12, 2022
@awvwgk awvwgk mentioned this pull request Feb 13, 2022
Closed
@awvwgk awvwgk added this to the v0.6.0 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKedward LKedward LKedward approved these changes

@awvwgk awvwgk awvwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@noisegul @LKedward @awvwgk