Skip to content

Ignore hidden source files#654

Merged
awvwgk merged 3 commits into
fortran-lang:mainfrom
noisegul:main
Feb 12, 2022
Merged

Ignore hidden source files#654
awvwgk merged 3 commits into
fortran-lang:mainfrom
noisegul:main

Conversation

@noisegul

Copy link
Copy Markdown
Contributor

Addresses #649
This change does not handle hidden directories, only files.

@awvwgk awvwgk self-requested a review January 28, 2022 07:15

@awvwgk awvwgk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. I'm fine with merging this as is.

Only one thing to discuss is how hidden directories should be handled, src/.dir/file.f90 will still be included with our current approach.

@LKedward LKedward left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this @noisegul - this LGTM 👍

@awvwgk awvwgk merged commit 57b5636 into fortran-lang:main Feb 12, 2022
@awvwgk awvwgk mentioned this pull request Feb 13, 2022
@awvwgk awvwgk added this to the v0.6.0 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants