Skip to content

Fix for non-portable GFortran -J flag in install script#692

Merged
awvwgk merged 5 commits intofortran-lang:mainfrom
wyphan:wyphan/fpm-bootstrap-fix
May 18, 2022
Merged

Fix for non-portable GFortran -J flag in install script#692
awvwgk merged 5 commits intofortran-lang:mainfrom
wyphan:wyphan/fpm-bootstrap-fix

Conversation

@wyphan
Copy link
Contributor

@wyphan wyphan commented Apr 23, 2022

No description provided.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use cd instead of pushd to avoid the issue with non-bash shells? Or if we want to stay with bash, why not just change the shebang to require a bash?

@wyphan
Copy link
Contributor Author

wyphan commented May 18, 2022

Can we use cd instead of pushd to avoid the issue with non-bash shells?

I wrote a custom pushd and popd (without the stack) to deal with non-bash shells, and that's the part that I need extra testing...

Or if we want to stay with bash, why not just change the shebang to require a bash?

I honestly prefer portability so fpm can be installed anywhere, even on minimalist distros like Alpine or TinyCore. This would be beneficial for Docker usage.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor comment left, otherwise looks good to me.

@awvwgk awvwgk merged commit aec789f into fortran-lang:main May 18, 2022
@wyphan wyphan deleted the wyphan/fpm-bootstrap-fix branch May 18, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants