Fix for non-portable GFortran -J flag in install script#692
Merged
awvwgk merged 5 commits intofortran-lang:mainfrom May 18, 2022
Merged
Fix for non-portable GFortran -J flag in install script#692awvwgk merged 5 commits intofortran-lang:mainfrom
-J flag in install script#692awvwgk merged 5 commits intofortran-lang:mainfrom
Conversation
awvwgk
requested changes
May 18, 2022
Member
awvwgk
left a comment
There was a problem hiding this comment.
Can we use cd instead of pushd to avoid the issue with non-bash shells? Or if we want to stay with bash, why not just change the shebang to require a bash?
Contributor
Author
I wrote a custom
I honestly prefer portability so fpm can be installed anywhere, even on minimalist distros like Alpine or TinyCore. This would be beneficial for Docker usage. |
awvwgk
reviewed
May 18, 2022
awvwgk
reviewed
May 18, 2022
awvwgk
approved these changes
May 18, 2022
Member
awvwgk
left a comment
There was a problem hiding this comment.
Only one minor comment left, otherwise looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.