-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix show-model option #693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the issue from #615 goes away for me with this patch. Thank you!
This is a relatively small correction, mainly to initialize the length of the allocatable array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @zoziha and many apologies for the delay in reviewing. I needed to double-check why this wasn't breaking the link_executable
example package test case, but this all looks fine to me.
The actual link_libraries
are populated in the add_executable_sources
routine which applies any executable-specific information from the manifest (such as link_libraries
). Your changes don't break this because of (re)allocation-on-assignment.
Init the `link_libraries` array length as 0
To close #615 .
Init the
f_source%link_libraries
array length as 0.