Some cleanups and minor fixes#701
Merged
zoziha merged 11 commits intofortran-lang:mainfrom Jul 22, 2022
Merged
Conversation
LKedward
reviewed
May 28, 2022
Member
There was a problem hiding this comment.
Thanks @zoziha - these changes all look fine to me. A couple of minor comments:
- Are you able to fix this line in
new-testas well:fpm/test/new_test/new_test.f90
Line 156 in cd8b5cc
- In
backend_output, perhaps we should just declareoverall_progresswith length7and remove the(:7)indexing?
Contributor
Author
|
Thanks for reviewing, @LKedward .
Sorry I didn't see this line of code before, I'll update my commit to fix it.
Nice suggestion ~ |
cd8b5cc to
88834b4
Compare
The wildcard command line usage on Windows to delete folders does not take effect in the actual test.
88834b4 to
5253412
Compare
LKedward
approved these changes
May 28, 2022
awvwgk
approved these changes
Jul 13, 2022
Member
awvwgk
left a comment
There was a problem hiding this comment.
Thanks for sharing. Looks good to me.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While using
fpmand reading thefpmsource code, I have found some small areas for improvement, as they tend to be small and have little impact on the overall functionality offpm, and it doesn't seem worth it to list them as a single PR.Updates
The work this PR does:
fnv_1areference;number_of_rows, remove unnecessary character reading;mkdirandos_delete_dir, the output format of which is somewhat complicated, and the current modification is unified with the following style:fpm/src/fpm_filesystem.F90
Line 906 in aec789f
==,/=, etc. are more intuitive and modern than.eq.,.ne.;new_testtest, the wildcard command line used in CMD shell on Windows did not actually take effect, which was corrected;📢 PS. I made a single commit record for each fix, it would be simple enough to review them in turn.