/fortressforever

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump pad + conc speed limiting persists for way too long #80

Closed
squeek502 opened this Issue Dec 2, 2014 · 0 comments

Comments

Assignees

@squeek502 squeek502

Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@squeek502
@squeek502
Member

squeek502 commented Dec 2, 2014

See: https://github.com/fortressforever/fortressforever/blob/beta/game_shared/ff/ff_grenade_concussion.cpp#L370

Currently, it'll limit your conc speed if you conc anytime within 5.2 seconds after using a jump pad. Meaning, you can use the jump pad, then prime a conc, and when that conc goes off your speed will still be limited.

Some possible solutions (using both would probably be best):

  • Reset m_flMancannonTime when the player jumps or IsOnGround
  • Lower the time to something more reasonable

@squeek502 squeek502 added bug priority:medium labels Dec 2, 2014

@squeek502 squeek502 self-assigned this Dec 2, 2014

@squeek502 squeek502 changed the title from Jump pad + conc limiting persists for way too long to Jump pad + conc speed limiting persists for way too long Dec 2, 2014

squeek502 added a commit that referenced this issue Dec 2, 2014

@squeek502
Fix conc speed being limited for too long after using a jump pad 
 * Fixes #80
 * Will stop limiting once the player is on the ground or in water, or after 3 seconds has passed since the jump pad was used
 * Also made the jump pad set players as in the air, so that m_flMancannonTime doesn't have to be checked in CFFGameMovement::CheckJumpButton (being in the air will force an early return)
f72b5f2

@squeek502 squeek502 referenced this issue Dec 2, 2014

Merged

Fix conc speed being limited for too long after using a jump pad #81

@squeek502 squeek502 added in progress needs review and removed priority:medium in progress labels Dec 2, 2014

@squeek502 squeek502 closed this in #81 Dec 10, 2014

@squeek502 squeek502 removed the needs review label Dec 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment