Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hud_deathnotice_highlightself by default and improve it a bit #296

Merged
merged 2 commits into from Sep 4, 2016

Conversation

Projects
None yet
2 participants
@squeek502
Copy link
Member

commented Jul 19, 2016

Closes #293

Looks like this:

ff_2fort0006_cr

squeek502 added some commits Jul 19, 2016

Add a border to hud_deathnotice_highlightself and make its BG dark
 - Uses default HUD foreground color by default
 - Highlight BG defaults to same as objective BG, differentiated by the border now

squeek502 added a commit to fortressforever/fortressforever-scripts that referenced this pull request Jul 19, 2016

@squeek502

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2016

This will almost certainly conflict with #288 (kill assists), so I'll wait to merge it until that gets merged. Any thoughts in the meantime, @AfterShockFF?

@AfterShockFF

This comment has been minimized.

Copy link
Member

commented Jul 22, 2016

Looks good to me 👍

@AfterShockFF

This comment has been minimized.

Copy link
Member

commented Sep 4, 2016

@squeek502 it doesnt appear to conflict. I've merged the kill assists PRs. Can you check this is all good to go and merge the two PRs?

@squeek502

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2016

If it doesn't conflict, it should be good to go.

@squeek502 squeek502 merged commit bef002b into beta Sep 4, 2016

@squeek502 squeek502 removed the needs review label Sep 4, 2016

@squeek502 squeek502 deleted the features/deathnotice-highlight branch Sep 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.